On Friday 24 Sep 2021 at 13:53:41 (+0100), Fuad Tabba wrote: > Many functions don't need access to the vcpu structure, but only > the hyp_state. Reduce their scope. > > This applies the semantic patches with the following commands: > FILES="$(find arch/arm64/kvm/hyp -name "*.[ch]" ! -name "debug-sr*") arch/arm64/include/asm/kvm_hyp.h" > spatch --sp-file cocci_refactor/add_hypstate.cocci $FILES --in-place > spatch --sp-file cocci_refactor/use_hypstate.cocci $FILES --in-place > > This patch adds variables that may be unused. These will be > removed at the end of this patch series. I'm guessing you decided to separate things out to make sure this patch is purely the result of a coccinelle run w/o manual changes? It looks like the patch to remove the unused variables is a 'COCCI' patch too, so maybe it would make sense to run it here directly after the first coccinelle run, and squash the result into this patch? The resulting patch would still be entirely auto-generated, and wouldn't have these somewhat odd unused variables. Thoughts? Thanks, Quentin
