On Friday 24 Sep 2021 at 13:53:34 (+0100), Fuad Tabba wrote: > +static void __vcpu_write_spsr(struct kvm_vcpu *vcpu, u64 val) > +{ > + __ctxt_write_spsr(&vcpu_ctxt(vcpu), val); > +} > + > +static void __vcpu_write_spsr_abt(struct kvm_vcpu *vcpu, u64 val) > +{ > + __ctxt_write_spsr_abt(&vcpu_ctxt(vcpu), val); > +} > + > +static void __vcpu_write_spsr_und(struct kvm_vcpu *vcpu, u64 val) > +{ > + __ctxt_write_spsr_und(&vcpu_ctxt(vcpu), val); > } I think you remove those at a later point in the series, do we really need to add them here? Cheers, Quentin