On Mon, 27 Sep 2021 13:49:28 +0200 Christoph Hellwig <hch@xxxxxx> wrote: > On Fri, Sep 24, 2021 at 12:37:55PM -0600, Alex Williamson wrote: > > > > + iommu->pgsize_bitmap = ULONG_MAX; > > > > > > I wonder if this needs the PAGE_MASK/SIZE stuff? > > > > > > iommu->pgsize_bitmap = ULONG_MASK & PAGE_MASK; > > > > > > ? > > > > > > vfio_update_pgsize_bitmap() goes to some trouble to avoid setting bits > > > below the CPU page size here > > > > Yep, though PAGE_MASK should already be UL, so just PAGE_MASK itself > > should work. The ULONG_MAX in the update function just allows us to > > detect sub-page, ex. if the IOMMU supports 2K we can expose 4K minimum, > > but we can't if the min IOMMU page is 64K. Thanks, > > Do you just want to update this or do you want a full resend of the > series? So long as we have agreement, I can do it inline. Are we doing s/ULONG_MAX/PAGE_MASK/ across both the diff and commit log? Thanks, Alex
