On Wed, Sep 22, 2021 at 01:09:57PM +0200, Paolo Bonzini wrote: > On 16/09/21 10:49, Andrew Jones wrote: > > > I was a little confused initially because we're allocating only one > > > dirty bitmap in userspace even when we have multiple slots, but that's > > > not a problem. > > It's also confusing to me. Wouldn't it be better to create a bitmap per > > slot? I think the new constraint that host mem must be a multiple of 64 > > is unfortunate. > > Yeah, I wouldn't mind if someone took a look at that. Also because anyway > this patch doesn't apply to master right now, I've queued 1-2 only. David posted a v2 on Sept. 17 with the bitmap split up per slot for patch 3/3. I think the other patches got some tweaks too. Thanks drew