On Mon, Sep 20, 2021 at 6:26 PM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 27/08/21 05:12, Zixuan Wang wrote: > > +static void setup_page_table(void) > > It would also be nice if cstart64.S reused setup_page_table, but unlike > GDT/IDT/TSS I guess it's not super-necessary. > > Paolo > I can update this in the next version. I can also move the page table definitions to a C file, maybe lib/x86/desc.c or lib/x86/vm.c? I'm not sure which file is better. Best regards, Zixuan