On Wed, Sep 15, 2021 at 1:08 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > Add dedicated helpers to emulate RESET instead of having the relevant code > scattered through vcpu_create() and vcpu_reset(). Paolo, I think this is > what you meant by "have init_vmcb/svm_vcpu_reset look more like the VMX > code"[*]. > > [*] https://lore.kernel.org/all/c3563870-62c3-897d-3148-e48bb755310c@xxxxxxxxxx/ That assumes that I remember what I meant :) but I do like it so yes, that was it. Especially the fact that init_vmcb now has a single caller. I would further consider moving save area initialization to *_vcpu_reset, and keeping the control fields in init_vmcb/vmcs. That would make it easier to relate the two functions to separate parts of the manuals. I should go back to KVM next week. Context switching with KVM Forum and Kangrejos this week made everything so much slower than I'd liked. Paolo
