On Fri, Sep 17, 2021 at 12:21:07PM +0530, Kirti Wankhede wrote: > > > On 9/17/2021 10:35 AM, Christoph Hellwig wrote: > > On Fri, Sep 17, 2021 at 04:49:41AM +0000, Tian, Kevin wrote: > > > > You just use the new style mdev API and directly call > > > > vfio_register_group_dev and it will pick up the > > > > parent->dev->iommu_group naturally like everything else using physical > > > > iommu groups. > > > > > > > > > Directly calling vfio_register_group_dev() doesn't work without linking > mdev->dev->iommu_group to mdev->type->parent->dev->iommu_group. You pass the PCI device, not the mdev to vfio_register_group_dev(). > > > For above usage (wrap pdev into mdev), isn't the right way to directly add > > > vendor vfio-pci driver since vfio-pci-core has been split out now? It's not > > > necessary to fake a mdev just for adding some mediation in the r/w path... > > > > Exactly. > > vfio-pci doesn't provide way to configure the device as mdev framework > provide using mdev_types. The linux standard is for a PCI PF driver to configure it's VFs, not a mdev or vfio. Jason
