Hi Boris,
I will update doc and commit per your feedback.
On 9/6/21 12:38 PM, Borislav Petkov wrote:
So you said earlier:
I followed the naming convension you recommended during the initial SEV driver
developement. IIRC, the main reason for us having to add "user" in it because
we wanted to distinguious that this structure is not exactly same as the what
is defined in the SEV-SNP firmware spec.
but looking at the current variant in the code, the structure in the SNP spec is
Table 91. Layout of the CMDBUF_SNP_GUEST_REQUEST Structure
which corresponds to struct snp_guest_request_data so you can call this one:
struct snp_guest_request_ioctl
and then it is perfectly clear what is what.
Noted.
"... which can be found at https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.amd.com%2Fsev%2F&data=04%7C01%7Cbrijesh.singh%40amd.com%7C9bc8f642dbad48a2a78008d9715d1edd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637665467074351191%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Iiz3emjR%2Blx8H73g2N0bOfPHeXXv%2FhLtlljOWNoD2mQ%3D&reserved=0.";
assuming that URL will keep its validity in the foreseeable future.
Unfortunately, the doc folks are replacing the current spec with the
new, and previous URLs are no longer valid. I will spell out the spec
version number so that anyone downloading the spec from bugzilla will
able to locate it.
thanks
Brijesh
