On 27/08/2021 1:26, Michael Roth wrote:
> From: Brijesh Singh <brijesh.singh@xxxxxxx>
>
> When SEV-SNP is enabled, the KVM_SNP_INIT command is used to initialize
> the platform. The command checks whether SNP is enabled in the KVM, if
> enabled then it allocates a new ASID from the SNP pool and calls the
> firmware to initialize the all the resources.
>
>From the KVM code ("[PATCH Part2 v5 24/45] KVM: SVM: Add
KVM_SEV_SNP_LAUNCH_START command") it seems that KVM_SNP_INIT does *not*
allocate the ASID; actually this is done in KVM_SEV_SNP_LAUNCH_START.
If that is indeed the case, I suggest removing this sentence here and
adding it in the appropriate QEMU step (patch 5?).
-Dov
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
> ---
> target/i386/sev-stub.c | 6 ++++++
> target/i386/sev.c | 27 ++++++++++++++++++++++++---
> target/i386/sev_i386.h | 1 +
> 3 files changed, 31 insertions(+), 3 deletions(-)
>
[...]
