On Sat, Aug 07, 2021, Paolo Bonzini wrote: > @@ -3919,25 +3915,25 @@ static int direct_page_fault(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault > else > write_lock(&vcpu->kvm->mmu_lock); > > - if (!is_noslot_pfn(pfn) && mmu_notifier_retry_hva(vcpu->kvm, mmu_seq, hva)) > + if (!is_noslot_pfn(fault->pfn) && mmu_notifier_retry_hva(vcpu->kvm, mmu_seq, fault->hva)) > goto out_unlock; > r = make_mmu_pages_available(vcpu); > if (r) > goto out_unlock; > > if (is_tdp_mmu_fault) > - r = kvm_tdp_mmu_map(vcpu, gpa, error_code, map_writable, fault->max_level, > - pfn, fault->prefault); > + r = kvm_tdp_mmu_map(vcpu, gpa, error_code, fault->map_writable, fault->max_level, > + fault->pfn, fault->prefault); > else > - r = __direct_map(vcpu, gpa, error_code, map_writable, fault->max_level, pfn, > - fault->prefault, fault->is_tdp); > + r = __direct_map(vcpu, gpa, error_code, fault->map_writable, fault->max_level, > + fault->pfn, fault->prefault, fault->is_tdp); More unwanted spaces! ERROR: code indent should use tabs where possible #95: FILE: arch/x86/kvm/mmu/mmu.c:3951: +^I^I^I^I fault->write, &fault->map_writable,$ ERROR: code indent should use tabs where possible #96: FILE: arch/x86/kvm/mmu/mmu.c:3952: +^I^I^I^I &fault->hva);$ ERROR: code indent should use tabs where possible #123: FILE: arch/x86/kvm/mmu/mmu.c:3987: +^I fault->gfn, fault->pfn, ACC_ALL, &r))$ ERROR: code indent should use tabs where possible #147: FILE: arch/x86/kvm/mmu/mmu.c:4008: +^I^I fault->pfn, fault->prefault, fault->is_tdp);$ total: 4 errors, 0 warnings, 180 lines checked