On Wed, Sep 1, 2021 at 2:23 PM Oliver Upton <oupton@xxxxxxxxxx> wrote: > > On Wed, Sep 01, 2021 at 09:14:01PM +0000, Raghavendra Rao Ananta wrote: > > Define the readl() and writel() functions for the guests to > > access (4-byte) the MMIO region. > > > > The routines, and their dependents, are inspired from the kernel's > > arch/arm64/include/asm/io.h and arch/arm64/include/asm/barrier.h. > > > > Signed-off-by: Raghavendra Rao Ananta <rananta@xxxxxxxxxx> > > --- > > .../selftests/kvm/include/aarch64/processor.h | 45 ++++++++++++++++++- > > 1 file changed, 44 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > > index c0273aefa63d..3cbaf5c1e26b 100644 > > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > > @@ -130,6 +130,49 @@ void vm_install_sync_handler(struct kvm_vm *vm, > > val; \ > > }) > > > > -#define isb() asm volatile("isb" : : : "memory") > > +#define isb() asm volatile("isb" : : : "memory") > > Is this a stray diff? > Oh no, that's intentional. Just trying to align with others below. Regards, Raghavendra > Otherwise: > > Reviewed-by: Oliver Upton <oupton@xxxxxxxxxx>