On Thu, 2009-11-05 at 09:01 -0800, John Admanski wrote: > Well, the drop_caches configs I definitely like. As a general rule I > think it's reasonable to translate most global defaults into a global > config setting. Ok, great, so 'drop_caches' will be kept as is. > > The sysinfo changes I'm a little less certain about. I do like the > idea of the sysinfo being more configurable in a way that doesn't > require making code changes, it's just that your proposed change just > targets one specific piece of sysinfo collection, and then wraps some > if blocks around it; I wish we could do something a little more > general. > > > I'm just picturing something more along the lines of breaking the > existing collection up into multiple functions (or classes) and then > letting you control which classes/functions actually get run with the > global config. Right now we just pile everything into one big class so > the only way to customize it at config time is to add a bunch of ifs, > like in your patch. It's not so bad for just enabling/disabling one > thing, but if the intention is to add more switches in the future it > doesn't really scale. Absolutely, I agree with you. I've spin this quick patch and put it as an RFC more to get some discussion about the subject. I am going to separate the drop_caches thing on its own patch (so it can be incorporated quickly) and will work on the sysinfo stuff, taking a more general approach. Thanks for your insight on this! Lucas -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
