On Fri, Aug 27, 2021 at 02:17:14AM +0000, Tian, Kevin wrote: > > flags suggests to me a bit field, but we can't have EMULATED|NOIOMMU. > > Should this be an enum iommu_type? > > > > and I wonder whether we should also define a type (VFIO_IOMMU) > for the remaining groups which are backed by IOMMU. This can be > set implicitly when the caller doesn't specify a specific type when > creating the group. It's not checked in any place now, but it might > be helpful for readability and diagnostic purpose? or change the > name to noiommu_flags then no confusion on its scope... If we move to a type field we should definitively define a value for the normal case as well. The advantage of the flags is that we can also use it for other needs it it arises. An emum OTOH would be easier to follow.
