On Thu, Aug 26, 2021 at 11:51:00AM +0100, Marc Zyngier wrote: > > > Patch 1 is unrelated, and is a fix for "KVM: arm64: Enforce reserved > > > bits for PSCI target affinities" on the kvmarm/next branch. Nothing > > > particularly hairy, just an unused param. > > > > Title line may not have been clear on this series, Patch 1 is a fix > > for the PSCI CPU_ON series that's in kvmarm/next to suppress a > > compiler warning. > > I'm not getting this warning. What are you compiling with? In general, > the compiler should shout about unused function parameters. Gah, this is just with local tooling. I'm unable to repro using GCC/Clang. I see that '-Wno-unused-parameter' is set alongside '-Wunused' when W=1. > > > Patch 5 is indirectly related to this series, and avoids compiler > > > reordering on PSCI calls in the selftest introduced by "selftests: KVM: > > > Introduce psci_cpu_on_test". > > > > This too is a fix for the PSCI CPU_ON series. Just wanted to raise it > > to your attention beyond the new feature I'm working on here. > > I'm not sure this actually need fixing. The dependencies on the input > and output will effectively prevent such reordering. That will > definitely be a good cleanup though, but maybe not worth taking out of > this series. Yep, you're right. There's an obvious dependency in the test that maintains program order. I realize that it is only the second test (patch 6 in this series) where things get hairy. Apologies for the noise. -- Thanks, Oliver
