On Thu, Aug 26, 2021 at 01:40:00AM +0000, Tian, Kevin wrote: > > group %d\n", > > iommu_group_id(iommu_group)); > > vfio_device_put(existing_device); > > - vfio_group_put(group); > > + vfio_iommu_group_put(iommu_group, device->dev); > > semantics change? the removed line is about vfio_group instead of > iommu_group. > > - /* Matches the get in vfio_register_group_dev() */ > > - vfio_group_put(group); > > + vfio_iommu_group_put(group->iommu_group, device->dev); > > ditto Yes, rebase/merge error.