On Tue, Aug 24, 2021 at 04:46:48PM +0200, Christoph Hellwig wrote: > The external_domain concept rather misleading and not actually needed. > Replace it with a list of mediated groups in struct vfio_iommu and > document the purpose. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/vfio/vfio_iommu_type1.c | 123 +++++++++++++++----------------- > 1 file changed, 57 insertions(+), 66 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > + /* > + * Tracks the fake iommu groups created by vfio to support mediated > + * devices. These are not backed by an actual IOMMU. > + */ > + struct list_head mediated_groups; Though again I'd prefer another name to mediated here.. These are domainless groups? Jason