Re: [PATCH 03/14] vfio: remove the iommudata check in vfio_noiommu_attach_group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 24, 2021 at 04:46:38PM +0200, Christoph Hellwig wrote:
> vfio_noiommu_attach_group has two callers:
> 
>  1) __vfio_container_attach_groups is called by vfio_ioctl_set_iommu,
>     which just called vfio_iommu_driver_allowed
>  2) vfio_group_set_container requires already checks ->noiommu on the
>     vfio_group, which is propagated from the iommudata in
>     vfio_create_group
> 
> so this check is entirely superflous and can be removed.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  drivers/vfio/vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux