Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Avi Kivity wrote:
> On 11/02/2009 06:20 PM, Jan Kiszka wrote:
>> This new substate exports all yet user-invisible states related to
>> exceptions, interrupts, and NMIs. Together with appropriate user space
>> changes, this fixes sporadic problems of vmsave/restore, live migration
>> and system reset.
>>    
> 
>> +		events.exception.injected = vcpu->arch.exception.pending;
>> +		events.exception.nr = vcpu->arch.exception.nr;
>> +		events.exception.error_code = vcpu->arch.exception.error_code;
>>    
> 
> we're missing has_error_code here.
> 

Isn't it statically defined by the arch? exception_has_error_code()
regenerates it (just like user land does).

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux