This series is a continuation to Sean's "[PATCH 0/2] VM: Fix a benign race
in kicking vCPUs" work and v2 for my "KVM: Optimize
kvm_make_vcpus_request_mask() a bit"/"KVM: x86: Fix stack-out-of-bounds
memory access from ioapic_write_indirect()" patchset.
Changes since v1:
- Drop inappropriate added 'likely' from kvm_make_vcpus_request_mask [Sean]
- Keep get_cpu()/put_cpu() and pass 'current_cpu' parameter to
kvm_make_vcpu_request() as a minor optimization [Sean]
>From Sean:
"Fix benign races when kicking vCPUs where the task doing the kicking can
consume a stale vcpu->cpu. The races are benign because of the
impliciations of task migration with respect to interrupts and being in
guest mode, but IMO they're worth fixing if only as an excuse to
document the flows.
Patch 2 is a tangentially related cleanup to prevent future me from
trying to get rid of the NULL check on the cpumask parameters, which
_looks_ like it can't ever be NULL, but has a subtle edge case due to the
way CONFIG_CPUMASK_OFFSTACK=y handles cpumasks."
Patch3 is a minor optimization for kvm_make_vcpus_request_mask() for big
guests.
Patch4 fixes a real problem with ioapic_write_indirect() KVM does
out-of-bounds access to stack memory.
Sean Christopherson (2):
KVM: Clean up benign vcpu->cpu data races when kicking vCPUs
KVM: Guard cpusmask NULL check with CONFIG_CPUMASK_OFFSTACK
Vitaly Kuznetsov (2):
KVM: Optimize kvm_make_vcpus_request_mask() a bit
KVM: x86: Fix stack-out-of-bounds memory access from
ioapic_write_indirect()
arch/x86/kvm/ioapic.c | 10 +++---
virt/kvm/kvm_main.c | 83 ++++++++++++++++++++++++++++++++-----------
2 files changed, 68 insertions(+), 25 deletions(-)
--
2.31.1
