On Tue, Aug 10, 2021 at 10:33:55AM +0200, Christoph Hellwig wrote:
> > - atomic_inc(&matrix_dev->available_instances);
> > - return -ENOMEM;
> > + ret = -ENOMEM;
> > + goto err_atomic;
>
> Nit: the label naming here is very strange. Somethig like
> err_dec_avaiable would be much more descriptive.
Sure
> > +static struct mdev_driver vfio_ap_matrix_driver = {
> > + .driver = {
> > + .name = "vfio_ap_mdev",
> > + .owner = THIS_MODULE,
> > + .mod_name = KBUILD_MODNAME,
>
> No need to set mod_name.
We talked about this before:
https://lore.kernel.org/kvm/20210326121048.GN2356281@xxxxxxxxxx/
Thanks,
Jason
