Re: [kvm-unit-tests RFC 14/16] x86 AMD SEV-ES: Copy UEFI #VC IDT entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Fri, Aug 20, 2021 at 4:50 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> > Signed-off-by: Zixuan Wang <zixuanwang@xxxxxxxxxx>
> > ---
> >  lib/x86/amd_sev.c | 10 ++++++++++
> >  lib/x86/amd_sev.h |  5 +++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/lib/x86/amd_sev.c b/lib/x86/amd_sev.c
> > index c2aebdf..04b6912 100644
> > --- a/lib/x86/amd_sev.c
> > +++ b/lib/x86/amd_sev.c
> > @@ -46,11 +46,21 @@ EFI_STATUS setup_amd_sev(void)
> >
> >  #ifdef CONFIG_AMD_SEV_ES
> >  EFI_STATUS setup_amd_sev_es(void){
> > +     struct descriptor_table_ptr idtr;
> > +     idt_entry_t *idt;
> > +
> >       /* Test if SEV-ES is enabled */
> >       if (!(rdmsr(MSR_SEV_STATUS) & SEV_ES_ENABLED_MASK)) {
> >               return EFI_UNSUPPORTED;
> >       }
> >
> > +     /* Copy UEFI's #VC IDT entry, so KVM-Unit-Tests can reuse it and does
>
> Nit, multiline comments should have a leading bare /*, i.e.
>
>         /*
>          * Copy ....
>          * not have to ...

Thanks for pointing this out, I will fix this issue in the next version.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux