On Tue, Aug 17, 2021 at 09:11:26AM +0100, Fuad Tabba wrote: > __init_el2_debug configures mdcr_el2 at initialization based on, > among other things, available hardware support. Trap deactivation > doesn't check that, so keep the initial value. > > No functional change intended. However, the value of mdcr_el2 > might be different after deactivating traps than it was before > this patch. I think this sentence is very confusing, so I'd remove it. I also don't think it's correct, as the EL2 initialisation code only manipulates the bits which are being masked here. So with that sentence removed: Acked-by: Will Deacon <will@xxxxxxxxxx> Will