On Mon, Aug 16, 2021 at 5:15 AM Andrew Jones <drjones@xxxxxxxxxx> wrote: > > On Fri, Aug 13, 2021 at 09:12:01PM +0000, Raghavendra Rao Ananta wrote: > > Hello, > > > > The patch series adds a KVM selftest to validate the behavior of > > ARM's generic timer (patch-10). The test programs the timer IRQs > > periodically, and for each interrupt, it validates the behaviour > > against the architecture specifications. The test further provides > > a command-line interface to configure the number of vCPUs, the > > period of the timer, and the number of iterations that the test > > has to run for. > > > > Since the test heavily depends on interrupts, the patch series also > > adds a basic support for ARM Generic Interrupt Controller v3 (GICv3) > > to the KVM's aarch64 selftest framework (patch-9). > > > > Furthermore, additional processor utilities such as accessing the MMIO > > (via readl/writel), read/write to assembler unsupported registers, > > basic delay generation, enable/disable local IRQs, spinlock support, > > and so on, are also introduced that the test/GICv3 takes advantage of. > > These are presented in patches 1 through 8. > > > > The patch series, specifically the library support, is derived from the > > kvm-unit-tests and the kernel itself. > > > > Hi Raghavendra, > > I appreciate the new support being added to aarch64 kselftests in order to > support new tests. I'm curious as to why the kvm-unit-tests timer test > wasn't extended instead, though. Also, I'm curious if you've seen any > room for improvements to the kvm-unit-tests code and, if so, if you plan > to submit patches for those improvements. Hi Andrew, Interesting question! It's more about ease and flexibility in controlling the guest via the VMM- Since arch_timer's interface is mostly per-CPU, we'd like to extend this test case to be more stressful, such as migrating the vCPUs across pCPUs rapidly, or even affining a large number of vCPUs to a single pCPU, and so on. On the other hand, since the patch series brings-in a lot of aarch64 goodies with it, such as interrupt support, it might encourage others to add more arch specific tests easily :) For example, we also plan to add tests that verifies KVM interface for interrupts, for which the GIC support in the series would come handy. I'm still gaining understanding of kvm-unit-tests. However, I'm curious to know your thoughts as well in-support of kvm-unit-tests. Unfortunately, I don't have any immediate plans to submit patches on arch_timer for kvm-unit-tests. Thanks, Raghavendra > > > Thanks, > drew >
