Re: [PATCH 01/11] Add shared memory hypercall to PV Linux guest.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/02/2009 06:18 PM, Gleb Natapov wrote:
+#define KVM_PV_SHM_VERSION 1
versions = bad, feature bits = good

I have both! Do you want me to drop version?

Yes.  Once a kernel is released you can't realistically change the version.

Some documentation for this?

Also, the name should reflect the pv pagefault use.  For other uses
we can register other areas.

I wanted it to be generic, but I am fine with making it apf specific.
It will allow to make it smaller too.

Maybe we can squeeze it into the page-fault error code?

would solve this.  I prefer using put_user() though than a permanent
get_user_pages().

I want to prevent it from been swapped out.

Since you don't prevent the page fault handler or code from being swapped out, you don't get anything out of it.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux