On Mon, Nov 02, 2009 at 11:28:38AM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Hi, > > > > current qemu-kvm.git gives me the message "qemu: warning: error while > > loading state for instance 0x0 of device 'kvmclock'" when I run a simple > > "savevm" followed by a "loadvm 1". What's broken here? > > OK, this is due to "KVM: add flags to kvm_clock_data" (958b0c5497): the > flags field is not cleared on KVM_SET_CLOCK. Will post a fix. > > But the above kernel commit is also broken: KVM_GET_CLOCK checks > uninitialized user_ns.flags (probably instead of the user's value). This > raises the question if the caller of KVM_GET_CLOCK is also supposed to > pass kvm_clock_data with flags cleared down to the kernel. Could someone > clarify this so I could fix it accordingly? Yes userspace is supposed to clear flags. My bad. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
