Hi Paolo, Thanks. I think Sean's suggestion makes sense. I will update it with that one and remove the 'fixes' line. Regards -Mingwei On Mon, Aug 2, 2021 at 9:53 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 02/08/21 18:17, Sean Christopherson wrote: > > > > Rather than adjusting the bitmap index, what about simply umping the bitmap size? > > IIRC, current CPUs have 512 ASIDs, counting ASID 0, i.e. bumping the size won't > > consume any additional memory. And if it does, the cost is 8 bytes... > > > > It'd be a bigger refactoring, but it should completely eliminate the mod-by-1 > > shenanigans, e.g. a partial patch could look like > > This is also okay by me if Mingwei agrees, of course. I have already > queued his patch, but I can replace it with one using a nr_asids-sized > bitmap too. > > Paolo >
