Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/queue] [cannot apply to vhost/linux-next v5.14-rc3 next-20210730] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Matlack/Improve-gfn-to-memslot-performance-during-page-faults/20210731-063919 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/0310eccd630f37e334f797d966bb515ab3c3b3d2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Matlack/Improve-gfn-to-memslot-performance-during-page-faults/20210731-063919 git checkout 0310eccd630f37e334f797d966bb515ab3c3b3d2 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): In file included from arch/x86/kvm/mmu/mmu.c:1936: arch/x86/kvm/mmu/mmu_audit.c: In function 'inspect_spte_has_rmap': >> arch/x86/kvm/mmu/mmu_audit.c:150:14: error: implicit declaration of function '__gfn_to_rmap'; did you mean 'gfn_to_rmap'? [-Werror=implicit-function-declaration] 150 | rmap_head = __gfn_to_rmap(gfn, rev_sp->role.level, slot); | ^~~~~~~~~~~~~ | gfn_to_rmap >> arch/x86/kvm/mmu/mmu_audit.c:150:12: warning: assignment to 'struct kvm_rmap_head *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 150 | rmap_head = __gfn_to_rmap(gfn, rev_sp->role.level, slot); | ^ arch/x86/kvm/mmu/mmu_audit.c: In function 'audit_write_protection': arch/x86/kvm/mmu/mmu_audit.c:203:12: warning: assignment to 'struct kvm_rmap_head *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 203 | rmap_head = __gfn_to_rmap(sp->gfn, PG_LEVEL_4K, slot); | ^ cc1: some warnings being treated as errors -- In file included from arch/x86/kvm/mmu/mmu.c:1936: arch/x86/kvm/mmu/mmu_audit.c: In function 'inspect_spte_has_rmap': >> arch/x86/kvm/mmu/mmu_audit.c:150:14: error: implicit declaration of function '__gfn_to_rmap'; did you mean 'gfn_to_rmap'? [-Werror=implicit-function-declaration] 150 | rmap_head = __gfn_to_rmap(gfn, rev_sp->role.level, slot); | ^~~~~~~~~~~~~ | gfn_to_rmap >> arch/x86/kvm/mmu/mmu_audit.c:150:12: warning: assignment to 'struct kvm_rmap_head *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 150 | rmap_head = __gfn_to_rmap(gfn, rev_sp->role.level, slot); | ^ arch/x86/kvm/mmu/mmu_audit.c: In function 'audit_write_protection': arch/x86/kvm/mmu/mmu_audit.c:203:12: warning: assignment to 'struct kvm_rmap_head *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 203 | rmap_head = __gfn_to_rmap(sp->gfn, PG_LEVEL_4K, slot); | ^ cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:271: arch/x86/kvm/mmu/mmu.o] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/Makefile.build:514: arch/x86/kvm] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1842: arch/x86] Error 2 make[1]: Target 'vmlinux' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'vmlinux' not remade because of errors. *** *** The source tree is not clean, please run 'make ARCH=x86_64 mrproper' *** in /kbuild/worktree/build-ktools-consumer *** make[2]: *** [Makefile:547: outputmakefile] Error 1 make[2]: Target 'syncconfig' not remade because of errors. make[1]: *** [Makefile:710: include/config/auto.conf.cmd] Error 2 make[1]: *** [include/config/auto.conf.cmd] Deleting file 'include/generated/autoconf.h' make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. *** *** The source tree is not clean, please run 'make ARCH=x86_64 mrproper' *** in /kbuild/worktree/build-ktools-consumer *** make[1]: *** [Makefile:547: outputmakefile] Error 1 In file included from <command-line>:32: include/linux/kconfig.h:7:10: fatal error: generated/autoconf.h: No such file or directory 7 | #include <generated/autoconf.h> | ^~~~~~~~~~~~~~~~~~~~~~ compilation terminated. In file included from <command-line>:32: include/linux/kconfig.h:7:10: fatal error: generated/autoconf.h: No such file or directory 7 | #include <generated/autoconf.h> | ^~~~~~~~~~~~~~~~~~~~~~ compilation terminated. In file included from <command-line>:32: include/linux/kconfig.h:7:10: fatal error: generated/autoconf.h: No such file or directory 7 | #include <generated/autoconf.h> | ^~~~~~~~~~~~~~~~~~~~~~ compilation terminated. In file included from scripts/selinux/mdp/mdp.c:22: include/linux/kconfig.h:7:10: fatal error: generated/autoconf.h: No such file or directory 7 | #include <generated/autoconf.h> | ^~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[4]: *** [scripts/Makefile.host:95: scripts/selinux/mdp/mdp] Error 1 make[4]: Target '__build' not remade because of errors. make[3]: *** [scripts/Makefile.build:496: scripts/selinux/mdp] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/Makefile.build:496: scripts/selinux] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1190: scripts] Error 2 In file included from tools/include/uapi/linux/ethtool.h:19, from xsk.c:18: usr/include/linux/if_ether.h:169:1: error: packed attribute is unnecessary for 'ethhdr' [-Werror=packed] 169 | } __attribute__((packed)); | ^ cc1: all warnings being treated as errors make[5]: *** [tools/build/Makefile.build:96: tools/bpf/resolve_btfids/staticobjs/xsk.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [Makefile:179: tools/bpf/resolve_btfids/staticobjs/libbpf-in.o] Error 2 make[3]: *** [Makefile:56: tools/bpf/resolve_btfids//libbpf.a] Error 2 make[2]: *** [Makefile:71: bpf/resolve_btfids] Error 2 make[1]: *** [Makefile:1930: tools/bpf/resolve_btfids] Error 2 make[1]: Target 'vmlinux' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'vmlinux' not remade because of errors. vim +150 arch/x86/kvm/mmu/mmu_audit.c 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 125 eb2591865a234c arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 126 static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 127 { bd80158aff71a8 arch/x86/kvm/mmu_audit.c Jan Kiszka 2011-09-12 128 static DEFINE_RATELIMIT_STATE(ratelimit_state, 5 * HZ, 10); 018aabb56d6109 arch/x86/kvm/mmu_audit.c Takuya Yoshikawa 2015-11-20 129 struct kvm_rmap_head *rmap_head; 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 130 struct kvm_mmu_page *rev_sp; 699023e239658e arch/x86/kvm/mmu_audit.c Paolo Bonzini 2015-05-18 131 struct kvm_memslots *slots; 699023e239658e arch/x86/kvm/mmu_audit.c Paolo Bonzini 2015-05-18 132 struct kvm_memory_slot *slot; 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 133 gfn_t gfn; 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 134 573546820b792e arch/x86/kvm/mmu/mmu_audit.c Sean Christopherson 2020-06-22 135 rev_sp = sptep_to_sp(sptep); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 136 gfn = kvm_mmu_page_get_gfn(rev_sp, sptep - rev_sp->spt); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 137 699023e239658e arch/x86/kvm/mmu_audit.c Paolo Bonzini 2015-05-18 138 slots = kvm_memslots_for_spte_role(kvm, rev_sp->role); 699023e239658e arch/x86/kvm/mmu_audit.c Paolo Bonzini 2015-05-18 139 slot = __gfn_to_memslot(slots, gfn); 699023e239658e arch/x86/kvm/mmu_audit.c Paolo Bonzini 2015-05-18 140 if (!slot) { bd80158aff71a8 arch/x86/kvm/mmu_audit.c Jan Kiszka 2011-09-12 141 if (!__ratelimit(&ratelimit_state)) 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 142 return; b034cf0105235e arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-12-23 143 audit_printk(kvm, "no memslot for gfn %llx\n", gfn); b034cf0105235e arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-12-23 144 audit_printk(kvm, "index %ld of sp (gfn=%llx)\n", 38904e128778c3 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-09-27 145 (long int)(sptep - rev_sp->spt), rev_sp->gfn); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 146 dump_stack(); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 147 return; 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 148 } 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 149 018aabb56d6109 arch/x86/kvm/mmu_audit.c Takuya Yoshikawa 2015-11-20 @150 rmap_head = __gfn_to_rmap(gfn, rev_sp->role.level, slot); 018aabb56d6109 arch/x86/kvm/mmu_audit.c Takuya Yoshikawa 2015-11-20 151 if (!rmap_head->val) { bd80158aff71a8 arch/x86/kvm/mmu_audit.c Jan Kiszka 2011-09-12 152 if (!__ratelimit(&ratelimit_state)) 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 153 return; b034cf0105235e arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-12-23 154 audit_printk(kvm, "no rmap for writable spte %llx\n", b034cf0105235e arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-12-23 155 *sptep); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 156 dump_stack(); 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 157 } 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 158 } 2f4f337248cd56 arch/x86/kvm/mmu_audit.c Xiao Guangrong 2010-08-30 159 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
