* Gleb Natapov <gleb@xxxxxxxxxx> wrote: > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index f4cee90..14707dc 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -952,6 +952,9 @@ do_page_fault(struct pt_regs *regs, unsigned long error_code) > int write; > int fault; > > + if (arch_handle_page_fault(regs, error_code)) > + return; > + This patch is not acceptable unless it's done cleaner. Currently we already have 3 callbacks in do_page_fault() (kmemcheck, mmiotrace, notifier), and this adds a fourth one. Please consolidate them into a single callback site, this is a hotpath on x86. And please always Cc: the x86 maintainers to patches that touch x86 code. Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
