On Wed, Jul 28, 2021 at 02:55:05PM +0200, Christoph Hellwig wrote: > On Wed, Jul 28, 2021 at 09:47:55AM -0300, Jason Gunthorpe wrote: > > So then we can write it like below? > > > +if PCI || MMU > > The || here should be &&. But otherwise, yes. Woops, thanks > > Unfortunately it deletes the nice > > menu structure that groups all the PCI drivers together like platform > > (and mdev in future). Not sure this loss is worth the backwards compat > > All the ther visible options should depend on VFIO_PCI not VFIO_PCI_CORE. > So we can still keep the same menu struture. It is the upcoming VFIO PCI drivers I'm looking at, eg the MLX5_VFIO_PCI It goes from this: --- VFIO Non-Privileged userspace driver framework [*] VFIO No-IOMMU support <*> VFIO support for PCI devices <*> Generic VFIO support for any PCI device [*] Generic VFIO PCI support for VGA devices [*] Generic VFIO PCI extensions for Intel graphics (GVT-d) <*> VFIO support for MLX5 PCI devices (NEW) <*> VFIO support for platform devices <*> VFIO support for AMBA devices <*> VFIO support for calxeda xgmac reset <*> VFIO support for AMD XGBE reset <*> VFIO support for Broadcom FlexRM reset <*> Mediated device driver framework <*> VFIO support for QorIQ DPAA2 fsl-mc bus devices To this: --- VFIO Non-Privileged userspace driver framework [*] VFIO No-IOMMU support <*> Generic VFIO support for any PCI device [*] Generic VFIO PCI support for VGA devices [*] Generic VFIO PCI extensions for Intel graphics (GVT-d) < > VFIO support for MLX5 PCI devices (NEW) <*> VFIO support for platform devices <*> VFIO support for AMBA devices <*> VFIO support for calxeda xgmac reset <*> VFIO support for AMD XGBE reset <*> VFIO support for Broadcom FlexRM reset <*> Mediated device driver framework <*> VFIO support for QorIQ DPAA2 fsl-mc bus devices Look at how "VFIO support for MLX5 PCI devices" has changed its position. Arnd's suggstion to add a menu seems OK, it gives another screen in kconfig but it does group them. My preference is the first version because it is simplest. Adding menu seems like something to do if we get > 5 more drivers. Just hiding it preserves back compat but hurts the UI. Honestly, I don't care very much, if Alex values kconfig backcompat higher than the UI then lets use the diff in my last email. Jason
