On 2021-07-23 14:38, Andrew Jones wrote:
On Fri, Jul 23, 2021 at 02:30:13PM +0100, Marc Zyngier wrote:
...
> > +
> > + ============== ========
> > ======================================
> > + Function ID: (uint32) 0xC6000004
> > + Arguments: (uint64) The base of the PG-sized IPA range
> > + that is allowed to be accessed as
> > + MMIO. Must aligned to the PG size (r1)
>
> align
Hmmm. Ugly mix of tab and spaces. I have no idea what the norm
is here, so I'll just put spaces. I'm sure someone will let me
know if I'm wrong! ;-)
Actually, my comment wasn't regarding the alignment of the text. I was
commenting that we should change 'aligned' to 'align' in the text.
(Sorry,
that was indeed ambiguous.) Hmm, it might be better to just add 'be',
i.e.
'be aligned'.
*blink*. duh, of course.
I'm not sure what to do about the tab/space mixing, but keeping it
consistent is good enough for me.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
