On Tue, Jul 20 2021, Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > From: Yishai Hadas <yishaih@xxxxxxxxxx> > > The only implementation of this in IGD returns a -ERRNO which is > implicitly cast through a size_t and then casted again and returned as a > ssize_t in vfio_pci_rw(). > > Fix the vfio_pci_regops->rw() return type to be ssize_t so all is > consistent. > > Fixes: 28541d41c9e0 ("vfio/pci: Add infrastructure for additional device specific regions") > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxx> This is missing your s-o-b... > --- > drivers/vfio/pci/vfio_pci_igd.c | 10 +++++----- > drivers/vfio/pci/vfio_pci_private.h | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > v2: > - Diff fixed to be against v5.14-rc1, woops Could you please also fix the subject prefix? The change itself looks good to me.