On Fri, Jul 02, 2021, isaku.yamahata@xxxxxxxxx wrote: > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > This is preparation for TDX support. > > Because SEAMCALL instruction requires VMX enabled, it needs to initialize > struct vmcs and load it before SEAMCALL instruction.[1] [2] Move out the > definition of vmcs into a common x86 header, arch/x86/include/asm/vmx.h, so > that seamloader code can share the same definition. ^^^^^^^^^^ SEAMLDR? I don't have a strong preference on what we call it, but we should be consistent in our usage. Same comments as the first two patches, without seeing the actual SEAMLDR code it's impossible review this patch. I certainly have no objection to splitting up this behemoth, but the series should be self contained (within reason).