On Wed, Oct 28, 2009 at 1:57 PM, Michael Goldish <mgoldish@xxxxxxxxxx> wrote: > One more comment on this patch: > > If you plan to make 'noinstall' the default build mode, then let's > not run the build test at all by default. If we run it with 'noinstall', > it will just run the preprocessor and postprocessor, and those will kill > any living VMs because no VMs are required for the build test. So a user > won't be able to run a reboot test, keep the VM alive, modify the config > file and then run a different test on the same living VM, because the > preprocessor of the second 'build' test will kill the VM. > > To avoid this, we can just remove the 'noinstall' variant from > kvm_build.cfg, and keep the 'only noinstall' statement. Because there's > no 'noinstall' variant, the resulting test list will be empty, so nothing > will run. We should probably add a comment reminding the user that it's > possible to disable installation by stating 'only noinstall' or 'only > nothing' (in case the user replaced 'noinstall' with something else). > > Alternatively, we can disable installation in the control file by commenting > out some line. Great idea, thanks :) - Lucas -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
