On Wed, Jun 23, 2021, Paolo Bonzini wrote: > On 22/06/21 19:57, Sean Christopherson wrote: > > + /* > > + * L1's CR4 and EFER are stuffed into vmcb01 by the caller. Note, when > > + * called via KVM_SET_NESTED_STATE, that state may_not_ match current > > + * vCPU state. CR0.WP is explicitly ignored, while CR0.PG is required. > > + */ > > "stuffed into" doesn't really match reality of vmentry, though it works for > KVM_SET_NESTED_STATE. What about a more neutral "The NPT format depends on > L1's CR4 and EFER, which is in vmcb01"? Ah, true. Works for me.