On 22/06/2021 16.12, Claudio Imbrenda wrote:
On Tue, 22 Jun 2021 15:55:16 +0200
Thomas Huth <thuth@xxxxxxxxxx> wrote:
According to the Principles of Operation, the epsw instruction
does not touch the second register if it is r0. With GCC we were
lucky so far that it never tried to use r0 here, but when compiling
the kvm-unit-tests with Clang, this indeed happens and leads to
very weird crashes. Thus let's make sure to never use r0 for the
second operand of the epsw instruction.
Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
Reviewed-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
maybe also mention in the patch description why you changed + to =
Yes, that makes sense. I'll add something like:
While we're at it, also change the constraint modifier from "+" to "=" since
these are only output parameters, not input.
Thomas
