Re: [PATCH v2 kvmtool 2/4] arm/fdt.c: Don't generate the node if generator function is NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 Jun 2021 10:21:26 +0100
Alexandru Elisei <alexandru.elisei@xxxxxxx> wrote:

> Print a more helpful debugging message when a MMIO device hasn't set a
> function to generate an FDT node instead of causing a segmentation fault by
> dereferencing a NULL pointer.
> 
> Signed-off-by: Alexandru Elisei <alexandru.elisei@xxxxxxx>

Thanks for the change.
One nit below, but anyway:

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

> ---
>  arm/fdt.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arm/fdt.c b/arm/fdt.c
> index 02091e9e0bee..7032985e99a3 100644
> --- a/arm/fdt.c
> +++ b/arm/fdt.c
> @@ -171,7 +171,12 @@ static int setup_fdt(struct kvm *kvm)
>  	dev_hdr = device__first_dev(DEVICE_BUS_MMIO);
>  	while (dev_hdr) {
>  		generate_mmio_fdt_nodes = dev_hdr->data;
> -		generate_mmio_fdt_nodes(fdt, dev_hdr, generate_irq_prop);
> +		if (generate_mmio_fdt_nodes) {
> +			generate_mmio_fdt_nodes(fdt, dev_hdr, generate_irq_prop);
> +		} else {
> +			pr_debug("Missing FDT node generator for MMIO device %d",
> +				 dev_hdr->dev_num);
> +		}

I think coding style says you don't need the brackets here.

Cheers,
Andre

>  		dev_hdr = device__next_dev(dev_hdr);
>  	}
>  




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux