On Thu, Jun 17, 2021 at 02:51:09AM +0300, Max Gurtovoy wrote: > > On 6/17/2021 2:44 AM, Jason Gunthorpe wrote: > > On Thu, Jun 17, 2021 at 02:42:46AM +0300, Max Gurtovoy wrote: > > > > > Do you see a reason not adding this alias for stub drivers but > > > adding it to vfio_pci drivers ? > > It creates uABI without a userspace user and that is strongly > > discouraged. The 'stub_pci:' prefix becomes fixed ABI. > so is it better to have "pci:v*d*sv*sd*bc*sc*i*" for stub drivers ? No, we don't want to convey any new information about stub drivers to userspace. > or not adding alias at all if stub flag is set ? Yes, just don't change it at all, IMHO. Jason
