> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Monday, June 14, 2021 9:38 PM > > On Mon, Jun 14, 2021 at 03:09:31AM +0000, Tian, Kevin wrote: > > > If a device can be always blocked from accessing memory in the IOMMU > > before it's bound to a driver or more specifically before the driver > > moves it to a new security context, then there is no need for VFIO > > to track whether IOASIDfd has taken over ownership of the DMA > > context for all devices within a group. > > I've been assuming we'd do something like this, where when a device is > first turned into a VFIO it tells the IOMMU layer that this device > should be DMA blocked unless an IOASID is attached to > it. Disconnecting an IOASID returns it to blocked. Or just make sure a device is in block-DMA when it's unbound from a driver or a security context. Then no need to explicitly tell IOMMU layer to do so when it's bound to a new driver. Currently the default domain type applies even when a device is not bound. This implies that if iommu=passthrough a device is always allowed to access arbitrary system memory with or without a driver. I feel the current domain type (identity, dma, unmanged) should apply only when a driver is loaded... > > > If this works I didn't see the need for vfio to keep the sequence. > > VFIO still keeps group fd to claim ownership of all devices in a > > group. > > As Alex says you still have to deal with the problem that device A in > a group can gain control of device B in the same group. There is no isolation in the group then how could vfio prevent device A from gaining control of device B? for example when both are attached to the same GPA address space with device MMIO bar included, devA can do p2p to devB. It's all user's policy how to deal with devices within the group. > > This means device A and B can not be used from to two different > security contexts. It depends on how the security context is defined. From iommu layer p.o.v, an IOASID is a security context which isolates a device from the rest of the system (but not the sibling in the same group). As you suggested earlier, it's completely sane if an user wants to attach devices in a group to different IOASIDs. Here I just talk about this fact. > > If the /dev/iommu FD is the security context then the tracking is > needed there. > As I replied to Alex, my point is that VFIO doesn't need to know the attaching status of each device in a group before it can allow user to access a device. As long as a device in a group either in block DMA or switch to a new address space created via /dev/iommu FD, there's no problem to allow user accessing it. User cannot do harm to the world outside of the group. User knows there is no isolation within the group. that is it. Thanks Kevin
