On Fri, Jun 11, 2021 at 04:20:36PM +0200, Joerg Roedel wrote: > I am not a fan of this, because its easily forgotten to add > local_irq_save()/local_irq_restore() calls around those. Yes, we can add > irqs_disabled() assertions to the functions, but we can as well just > disable/enable IRQs in them. Only the previous value of EFLAGS.IF needs > to be carried from one function to the other. Wrappers: sev_es_get_ghcb(): local_irq_save() __sev_es_get_ghcb() and the reverse. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette