On 09/06/21 16:51, Oliver Upton wrote:
- You seem to allow each vcpu to get its own offset. I don't think
that's right. The architecture defines that all PEs have the same
view of the counters, and an EL1 guest should be given that
illusion.
Agreed. I would have preferred a VM-wide ioctl to do this, but since
x86 explicitly allows for drifted TSCs that can't be the case in a
generic ioctl. I can do the same broadcasting as we do in the case of
a VMM write to CNTVCT_EL0.
If you use VM-wide GET/SET_DEVICE_ATTR, please make it retrieve the host
CLOCK_REALTIME and counter at the same time.
Paolo
