> On Jun 6, 2021, at 1:00 AM, Yi Sun <yi.sun@xxxxxxxxx> wrote:
>
> Create ISO image according to the configure file unittests.cfg,
> where describes the parameters of each test case.
>
> The grub.cfg in ios/boot/grub/ looks as following, taking case
> 'vmx_apicv_test' as an example:
>
> set timeout=0
> set default=0
>
> menuentry "vmx.elf" {
> multiboot /boot/vmx.elf apic_reg_virt_test virt_x2apic_mode_test
> module /boot/module
> boot
> }
>
> [1] All parameters are from '-append xxx' in the unittests.cfg.
> [2] The file 'module' is a fixed file that can be passed by paramters
> of script ./create_iso.sh.
>
> Signed-off-by: Yi Sun <yi.sun@xxxxxxxxx>
Thanks Yi!
I gave it a spin and it works nicely.
One minor issue that I think worth fixing is silent failures. Initially, the script failed silently since I did not have the xorriso package installed on my Ubuntu (the error message "grub-mkrescue: error: xorriso not found.” was suppressed). It would be nicer to print some error message in such case.
Two general notes regarding patch submission:
1. Please include a cover-letter (using git’s “--cover-letter” option), which would include general description of what the patch-set does. In addition, track changes between the versions.
2. Please use the same version for all patches. You can use git “-v” option for this matter.
Thanks again,
Nadav
