On Wed, Jun 02, 2021 at 04:40:28PM -0700, Ricardo Koller wrote: > On Mon, May 31, 2021 at 12:33:40PM +0200, Andrew Jones wrote: > > We already break register lists into sublists that get selected based > > on vcpu config. However, since we only had two configs (vregs and sve), > > we didn't structure the code very well to manage them. Restructure it > > now to more cleanly handle register sublists that are dependent on the > > vcpu config. > > > > This patch has no intended functional change (except for the vcpu > > config name now being prepended to all output). > > > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > > Reviewed-by: Ricardo Koller <ricarkol@xxxxxxxxxx> Thanks > I don't think it matters that much for this test, but ".capability = 0" > is already taken: > > #define KVM_CAP_IRQCHIP 0 > This is a good point, and I should have checked it before assuming I could use zero for "no special capabilities". I'm tempted to leave this as is for now though. If we ever need to consider KVM_CAP_IRQCHIP, then we can cross that bridge later. Thanks, drew