Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action

[Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>]

31.05.2021 15:38, Valeriy Vdovin wrote:
> Introducing new qapi method 'query-kvm-cpuid'. This method can be used to
> get virtualized cpu model info generated by QEMU during VM initialization in
> the form of cpuid representation.

[..]

>      "ebx": 0,
>    },
>    {
>      "eax": 13,
>      "edx": 1231384169,
>      "in_eax": 0,
>      "ecx": 1818588270,
>      "ebx": 1970169159,
>    },
>    {
>      "eax": 198354,
>      "edx": 126614527,
>    ....
>
> Signed-off-by: Valeriy Vdovin <valeriy.vdovin@xxxxxxxxxxxxx>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>


> v2: - Removed leaf/subleaf iterators.
>      - Modified cpu_x86_cpuid to return false in cases when count is
>        greater than supported subleaves.

[..]

> +# @in_eax: CPUID argument in eax
> +# @in_ecx: CPUID argument in ecx
> +# @eax: eax
> +# @ebx: ebx
> +# @ecx: ecx
> +# @edx: edx
> +#
> +# Since: 6.1
> +##
> +{ 'struct': 'CpuidEntry',
> +  'data': { 'in_eax' : 'uint32',
> +            '*in_ecx' : 'uint32',

I'm not sure, probably '-' instead of '_' is preferable in QAPI.

> +            'eax' : 'uint32',
> +            'ebx' : 'uint32',
> +            'ecx' : 'uint32',
> +            'edx' : 'uint32'
> +          },
> +  'if': 'defined(TARGET_I386) && defined(CONFIG_KVM)' }
> +


--
Best regards,
Vladimir