Re: [kvm-unit-tests PATCH] s390x: unify header guards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> writes:

> On Tue,  1 Jun 2021 18:15:25 +0200
> Cornelia Huck <cohuck@xxxxxxxxxx> wrote:
>
>> Let's unify the header guards to _ASM_S390X_FILE_H_ respectively
>> _S390X_FILE_H_. This makes it more obvious what the file is
>> about, and avoids possible name space collisions.
>> 
>> Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx>
>
> LGTM, but... what about the other architectures? I think we should 
> try to standardize more generally

See my comment below :)

I think it would make sense to standardize all architectures; but I
would also like some feedback on the format I have chosen.

>
>> ---
>> 
>> Only did s390x for now; the other archs seem to be inconsistent in
>> places as well, and I can also try to tackle them if it makes sense.
>> 




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux