On 5/27/21 7:23 AM, Borislav Petkov wrote: > On Thu, May 27, 2021 at 07:12:00AM -0500, Brijesh Singh wrote: >> Let me know if you still think that snp_prep_memory() helper is required. > Yes, I still do think that because you can put the comment and all > the manupulation of parameters in there and have a single oneliner in > probe_roms.c: > > snp_prep_memory(...); > > and have the details in sev.c where they belong. Okay, I will add the helper.