On Wed, May 26, 2021, Shaokun Zhang wrote: > Hi Sean, > > On 2021/5/26 0:09, Sean Christopherson wrote: > > Rather than simply delete the extra declaration, what about converting this to > > static inline and opportunistically deleting the duplicate? The implementation > > It seems that you want to make it static inline in mmu_internal.h, right? Yep. > > is a single operation and this is MMU-internal, i.e. there's no need to export > > and limited exposure of nx_huge_pages to other code. > > If is_nx_huge_page_enabled is inline in mmu_internal.h, nx_huge_pages will be > external in mmu_internal.h and exposed to other code. Do I miss something? Yes, it will be theoretically exposed to other code, but as the name suggests, mmu_internal.h should not be included by anything outside of mmu/, and of course we can reject patches that try to access nx_guest_pages directly.
