Hi Eric, On Tue, 18 May 2021 12:48:41 +0100, Auger Eric <eric.auger@xxxxxxxxxx> wrote: > > Hi David, Marc, > [...] > >> --- a/scripts/kallsyms.c > >> +++ b/scripts/kallsyms.c > >> @@ -109,6 +109,7 @@ static bool is_ignored_symbol(const char *name, char type) > >> ".LASANPC", /* s390 kasan local symbols */ > >> "__crc_", /* modversions */ > >> "__efistub_", /* arm64 EFI stub namespace */ > >> + "__kvm_nvhe_", /* arm64 non-VHE KVM namespace */ > > The addition of this line seems to have introduced errors on the > > 'vmlinux symtab matches kallsyms' perf test (perf test -v 1) which fails > > on aarch64 for all __kvm_nvhe_ prefixed symbols, like > > > > ERR : <addr> : __kvm_nvhe___invalid not on kallsyms > > ERR : <addr> : __kvm_nvhe___do_hyp_init not on kallsyms > > ERR : <addr> : __kvm_nvhe___kvm_handle_stub_hvc not on kallsyms > > ERR : <addr> : __kvm_nvhe_reset not on kallsyms > > ../.. > > > > I understand we willingly hided those symbols from /proc/kallsyms. Do > > you confirm the right fix is to upgrade the perf test suite accordingly? > > Were you eventually able to reproduce? Unfortunately not, I always end-up with the test failing even if I add the symbols back. I must be doing something wrong... M. -- Without deviation from the norm, progress is not possible.
