On Tue, May 11, 2021 at 08:21:20PM +0000, David Matlack wrote: > If a KVM selftest is run on a machine without /dev/kvm, it will exit > silently. Make it easy to tell what's happening by printing an error > message. > > Opportunistically consolidate all codepaths that open /dev/kvm into a > single function so they all print the same message. > > This slightly changes the semantics of vm_is_unrestricted_guest() by > changing a TEST_ASSERT() to exit(KSFT_SKIP). However > vm_is_unrestricted_guest() is only called in one place > (x86_64/mmio_warning_test.c) and that is to determine if the test should > be skipped or not. > > Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx> > --- > .../testing/selftests/kvm/include/kvm_util.h | 1 + > tools/testing/selftests/kvm/lib/kvm_util.c | 45 +++++++++++++------ > .../selftests/kvm/lib/x86_64/processor.c | 16 ++----- > .../kvm/x86_64/get_msr_index_features.c | 8 +--- > 4 files changed, 38 insertions(+), 32 deletions(-) > Hi David, You could have grabbed my r-b from v3, but anyway here it is again Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx> Thanks, drew
