On Fri, May 07, 2021 at 07:08:31PM -0300, Marcelo Tosatti wrote:
> > Wondering whether we should add a pi_test_on() check in kvm_vcpu_has_events()
> > somehow, so that even without customized ->vcpu_check_block we should be able
> > to break the block loop (as kvm_arch_vcpu_runnable will return true properly)?
>
> static int kvm_vcpu_check_block(struct kvm_vcpu *vcpu)
> {
> int ret = -EINTR;
> int idx = srcu_read_lock(&vcpu->kvm->srcu);
>
> if (kvm_arch_vcpu_runnable(vcpu)) {
> kvm_make_request(KVM_REQ_UNHALT, vcpu); <---
> goto out;
> }
>
> Don't want to unhalt the vcpu.
Could you elaborate? It's not obvious to me why we can't do that if
pi_test_on() returns true.. we have pending post interrupts anyways, so
shouldn't we stop halting? Thanks!
--
Peter Xu
