On Mon, May 10, 2021 at 9:33 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 10/05/21 18:14, Ben Gardon wrote: > >> Possibly stupid (or at least lazy) question: why can't it be a "normal" > >> static inline function? > > That was my initial approach (hence the leftover inline) but I got > > some warnings about a forward declaration of struct kvm because > > arch/x86/include/asm/kvm_host.h doesn't include virt/kvm/kvm_host.h. > > Maybe there's a way to fix that, but I didn't want to mess with it. > > > > Let's just use the field directly. That works for me too. I moved to the wrapper because adding the smp_load_acquire and a comment explaining why we were doing that looked bloated and I thought it would be easier to document in one place, but it's not that much bloat, and having the subtleties documented directly in the function is probably clearer for readers anyway. > > Paolo >
